Re: [PR] [VARIANT] Add support for DataType::Utf8/LargeUtf8/Utf8View for cast_to_variant [arrow-rs]

[via GitHub]

carpecodeum commented on PR #8089:
URL: https://github.com/apache/arrow-rs/pull/8089#issuecomment-3189134606

   > Hi @carpecodeum -- I can't merge this PR because github says it has a 
conflict (and since I can't push commits to your fork I can't resolve them 
myself)
   > 
   > <img alt="Screenshot 2025-08-13 at 12 33 55 PM" width="989" height="366" 
src="https://private-user-images.githubusercontent.com/490673/477649712-052cf6f3-370e-44b2-8e8f-23eea778dd15.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTUxODk0MTcsIm5iZiI6MTc1NTE4OTExNywicGF0aCI6Ii80OTA2NzMvNDc3NjQ5NzEyLTA1MmNmNmYzLTM3MGUtNDRiMi04ZThmLTIzZWVhNzc4ZGQxNS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwODE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDgxNFQxNjMxNTdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01ZmUzYjc3NTUxYTNmNWFkM2U4YmU0MmU0YThjNTU1NDU4MTZkM2U0Yzk2ZTdhNWYwOTU0MTIxYzI2OTgxYjdkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.3r86hCFPAKSlq8ZCUGgGLMlmeQnPQ5L03O4VlOF_AbY";>
   > Could you
   > 
   > 1. Please resolve the conflicts
   > 2. Let me know if you plan to address @klion26 's comment [[VARIANT] Add 
support for DataType::Utf8/LargeUtf8/Utf8View for cast_to_variant #8089 
(comment)](https://github.com/apache/arrow-rs/pull/8089#discussion_r2265589993) 
(I don't think it is necessary but I do think it would improve the code -- we 
can also do it as a follow on PR too)
   
   Yes, I will make those changes as well, totally missed this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org