WillAyd commented on code in PR #47298:
URL: https://github.com/apache/arrow/pull/47298#discussion_r2265324688
##########
cpp/src/arrow/integration/meson.build:
##########
@@ -20,8 +20,13 @@ install_headers(['json_integration.h'])
exc = executable(
'arrow-json-integration-test',
sources: ['json_integration_test.cc'],
- dependencies: [arrow_dep, rapidjson_dep, gflags_dep, gtest_dep],
- link_with: [arrow_test_lib],
+ dependencies: [
+ arrow_dep,
+ arrow_testing_dep,
+ rapidjson_dep,
+ gflags_dep,
+ gtest_dep,
Review Comment:
Its a bit confusing and there might be a better way to word things, but with
this PR we now have a few dependencies being declared:
- arrow_testing_dep, which just exposes the testing library
- arrow_test_dep, which exposes multiple dependencies that are used to
compile and run tests in arrow
- arrow_test_dep_no_main which is used by tests that declare their own main
function
I could use `arrow_test_dep_no_main` here instead; it would add a few
superfluous dependencies but is closer to what this test requires
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
