kou commented on code in PR #47298:
URL: https://github.com/apache/arrow/pull/47298#discussion_r2268318761
##########
cpp/src/arrow/meson.build:
##########
@@ -569,20 +569,36 @@ else
gmock_dep = disabler()
endif
-arrow_test_lib = static_library(
- 'arrow_testing',
- sources: arrow_testing_srcs,
- dependencies: [arrow_dep, filesystem_dep, gmock_dep, gtest_main_dep],
-)
+if needs_testing
+ arrow_testing_lib = static_library(
+ 'arrow_testing',
+ sources: arrow_testing_srcs,
+ dependencies: [arrow_dep, filesystem_dep, gmock_dep, gtest_main_dep],
Review Comment:
Should we use `gtest_dep` not `gtest_main_dep` here because
`libarrow_testing` doesn't need `main()`?
```suggestion
dependencies: [arrow_dep, filesystem_dep, gmock_dep, gtest_dep],
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
