klion26 commented on code in PR #8105:
URL: https://github.com/apache/arrow-rs/pull/8105#discussion_r2265586437
##########
parquet-variant-compute/src/cast_to_variant.rs:
##########
@@ -39,23 +41,28 @@ macro_rules! primitive_conversion {
}
}};
}
-
-/// Convert the input array to a `VariantArray` row by row, using `method`
-/// to downcast the generic array to a specific array type and `cast_fn`
-/// to transform each element to a type compatible with Variant
-macro_rules! cast_conversion {
- ($t:ty, $method:ident, $cast_fn:expr, $input:expr, $builder:expr) => {{
- let array = $input.$method::<$t>();
- for i in 0..array.len() {
- if array.is_null(i) {
- $builder.append_null();
- continue;
- }
- let cast_value = $cast_fn(array.value(i));
- $builder.append_variant(Variant::from(cast_value));
- }
- }};
-}
+//
+// /// Convert the input array to a `VariantArray` row by row, using `method`
Review Comment:
Comment out this for the `draft` version; I will remove it in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
