hiroyuki-sato opened a new pull request, #47322:
URL: https://github.com/apache/arrow/pull/47322
### Rationale for this change
This is the sub issue #44748.
* SC1091: Not following
* SC2012: Use `find` instead of `ls` to better handle non-alphanumeric
filenames.
* SC2086: Double quote to prevent globbing and word splitting
```
heck ci/scripts/python_sdist_test.sh
In ci/scripts/python_sdist_test.sh line 56:
sdist=$(ls ${arrow_dir}/python/dist/pyarrow-*.tar.gz | sort -r | head -n1)
^-- SC2012 (info): Use find instead of ls to better handle
non-alphanumeric filenames.
^----------^ SC2086 (info): Double quote to prevent globbing
and word splitting.
Did you mean:
sdist=$(ls "${arrow_dir}"/python/dist/pyarrow-*.tar.gz | sort -r | head
-n1)
In ci/scripts/python_sdist_test.sh line 60:
. "${ARROW_PYTHON_VENV}/bin/activate"
^-- SC1091 (info): Not following: ./bin/activate: openBinaryFile: does
not exist (No such file or directory)
In ci/scripts/python_sdist_test.sh line 63:
${PYTHON:-python} -m pip install ${sdist}
^------^ SC2086 (info): Double quote to
prevent globbing and word splitting.
Did you mean:
${PYTHON:-python} -m pip install "${sdist}"
In ci/scripts/python_sdist_test.sh line 65:
pytest -r s ${PYTEST_ARGS:-} --pyargs pyarrow
^--------------^ SC2086 (info): Double quote to prevent globbing
and word splitting.
Did you mean:
pytest -r s "${PYTEST_ARGS:-}" --pyargs pyarrow
For more information:
https://www.shellcheck.net/wiki/SC1091 -- Not following: ./bin/activate:
op...
https://www.shellcheck.net/wiki/SC2012 -- Use find instead of ls to better
...
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing
...
```
### What changes are included in this PR?
* SC1091: Skip file check
* SC2012: Use `find` instead of `ls` command
* SC2086: Quote variables
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
