hiroyuki-sato commented on code in PR #47322:
URL: https://github.com/apache/arrow/pull/47322#discussion_r2272793250
##########
ci/scripts/python_sdist_test.sh:
##########
@@ -53,13 +53,17 @@ fi
if [ -n "${PYARROW_VERSION:-}" ]; then
sdist="${arrow_dir}/python/dist/pyarrow-${PYARROW_VERSION}.tar.gz"
else
- sdist=$(ls ${arrow_dir}/python/dist/pyarrow-*.tar.gz | sort -r | head -n1)
+ sdist=$( find "${arrow_dir}/python/dist/" -maxdepth 1 -name
'pyarrow-*.tar.gz' -print | sort -r | head -n1 )
Review Comment:
Thanks I quoted `"${arrow_dir}"` for avoiding the following error.
```
In ci/scripts/python_sdist_test.sh line 56:
sdist=$(echo ${arrow_dir}/python/dist/pyarrow-*.tar.gz | sort -r | head
-n1)
^----------^ SC2086 (info): Double quote to prevent globbing
and word splitting.
Did you mean:
sdist=$(echo "${arrow_dir}"/python/dist/pyarrow-*.tar.gz | sort -r | head
-n1)
For more information:
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
