etseidl commented on code in PR #8071:
URL: https://github.com/apache/arrow-rs/pull/8071#discussion_r2274872787
##########
parquet/src/file/metadata/reader.rs:
##########
@@ -118,27 +139,49 @@ impl ParquetMetaDataReader {
}
/// Enable or disable reading the page index structures described in
- /// "[Parquet page index]: Layout to Support Page Skipping". Equivalent to:
- /// `self.with_column_indexes(val).with_offset_indexes(val)`
+ /// "[Parquet page index]: Layout to Support Page Skipping".
///
/// [Parquet page index]:
https://github.com/apache/parquet-format/blob/master/PageIndex.md
+ #[deprecated(since = "56.0.0", note = "Use `with_page_index_policy`
instead")]
pub fn with_page_indexes(self, val: bool) -> Self {
- self.with_column_indexes(val).with_offset_indexes(val)
+ let policy = PageIndexPolicy::from(val);
+ self.with_column_index_policy(policy)
+ .with_offset_index_policy(policy)
}
/// Enable or disable reading the Parquet [ColumnIndex] structure.
///
/// [ColumnIndex]:
https://github.com/apache/parquet-format/blob/master/PageIndex.md
- pub fn with_column_indexes(mut self, val: bool) -> Self {
- self.column_index = val;
- self
+ #[deprecated(since = "56.0.0", note = "Use `with_column_index_policy`
instead")]
+ pub fn with_column_indexes(self, val: bool) -> Self {
+ let policy = PageIndexPolicy::from(val);
+ self.with_column_index_policy(policy)
}
/// Enable or disable reading the Parquet [OffsetIndex] structure.
///
/// [OffsetIndex]:
https://github.com/apache/parquet-format/blob/master/PageIndex.md
- pub fn with_offset_indexes(mut self, val: bool) -> Self {
- self.offset_index = val;
+ #[deprecated(since = "56.0.0", note = "Use `with_offset_index_policy`
instead")]
Review Comment:
```suggestion
#[deprecated(since = "56.1.0", note = "Use `with_offset_index_policy`
instead")]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
