codephage2020 commented on code in PR #8093:
URL: https://github.com/apache/arrow-rs/pull/8093#discussion_r2283896085
##########
parquet-variant-compute/src/variant_array.rs:
##########
@@ -187,6 +187,7 @@ impl VariantArray {
typed_value_to_variant(typed_value, index)
}
}
+ ShreddingState::AllNull { .. } => Variant::Null,
Review Comment:
You are absolutely correct. Subsequently, we might need a value_opt() method
that returns Option<Variant> to properly handle SQL NULL semantics for shredded
fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
