codephage2020 commented on PR #8093:
URL: https://github.com/apache/arrow-rs/pull/8093#issuecomment-3199333438
> This PR appears to have accumulated some conflicts; I am happy to help
resolve them / get this PR merged but I wanted to check with you first
First, I sincerely apologize for the delayed response. After carefully
reviewing all the feedback, I initially struggled with determining the
necessary changes and how to respond—I wasn’t entirely confident in my
understanding, which led to the unintended hold-up. My apologies again for the
wait.
I’ve now added some comments.
Additionally, I list some comments outlining potential next steps or action
items in the following, FYI.
1. VariantArray::value() to return Option<Variant> to properly distinguish
SQL NULL vs JSON null
2. Add validation to reject top-level AllNull variants entirely
3. Pass schema information to ShreddingState::try_new() to detect context
4. Split AllNull handling into separate variants for top-level vs shredded
contexts
Please feel free to correct or refine them—I’d greatly appreciate your
guidance to ensure we move forward effectively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
