daniel-adam-tfs commented on code in PR #477:
URL: https://github.com/apache/arrow-go/pull/477#discussion_r2281737562


##########
parquet/file/file_reader_test.go:
##########
@@ -927,3 +928,61 @@ func TestListColumns(t *testing.T) {
                }
        }
 }
+
+func BenchmarkReadInt32Column(b *testing.B) {
+       b.Skip("rle-dict-int32-snappy.parquet not available")

Review Comment:
   @zeroshade I've generated this file with a single int32 column, 1 000 000 
rows overall, 10 row groups and 1 00 unique values, v2 format and snappy 
compression. It's 113KB in size, if there's no other file you'd prefer to use 
for testing then we can add it to the data repo and remove the `b.Skip` call.



##########
parquet/file/file_reader_test.go:
##########
@@ -927,3 +928,61 @@ func TestListColumns(t *testing.T) {
                }
        }
 }
+
+func BenchmarkReadInt32Column(b *testing.B) {
+       b.Skip("rle-dict-int32-snappy.parquet not available")

Review Comment:
   @zeroshade I've generated this file with a single int32 column, 1 000 000 
rows overall, 10 row groups and 100 unique values, v2 format and snappy 
compression. It's 113KB in size, if there's no other file you'd prefer to use 
for testing then we can add it to the data repo and remove the `b.Skip` call.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to