daniel-adam-tfs commented on code in PR #477:
URL: https://github.com/apache/arrow-go/pull/477#discussion_r2297894865
##########
parquet/internal/utils/bit_reader.go:
##########
@@ -152,24 +169,67 @@ func (b *BitReader) GetAligned(nbytes int, v interface{})
bool {
if n != nbytes {
return false
}
+
// zero pad the bytes
- memory.Set(b.raw[n:typBytes], 0)
-
- switch v := v.(type) {
Review Comment:
Annoying, I benchmarked it now and the non-generic version is about 2%
faster according to the benchmark. In this case I'm alright with a little bit
of code duplication for 2% better performance, but what's your call?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
