scovich opened a new pull request, #8189:
URL: https://github.com/apache/arrow-rs/pull/8189

   - Stacked on https://github.com/apache/arrow-rs/pull/8185, only review the 
last commit in this PR
   
   # Which issue does this PR close?
   
   - Closes https://github.com/apache/arrow-rs/issues/8188
   
   # Rationale for this change
   
   Today, `ValueBuilder::[try_]append_variant` unconditionally creates and uses 
a `ParentState::Variant`, but that is incorrect when the caller is a 
`ListBuilder` or `ObjectBuilder`. Rework the API so that the caller passes 
their parent state, thus ensuring proper rollback in all situations.
   
   This is also a building block that will eventually let us simplify 
`VariantArrayBuilder` to use a `ValueBuilder` directly, instead of a 
`VariantBuilder`.
   
   # What changes are included in this PR?
   
   Several methods become associated functions.
   
   # Are these changes tested?
   
   Existing unit tests cover this refactor.
   
   # Are there any user-facing changes?
   
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to