ianmcook commented on code in PR #3320: URL: https://github.com/apache/arrow-adbc/pull/3320#discussion_r2289341054
########## docs/source/format/driver_manifests.rst: ########## @@ -452,9 +456,15 @@ Windows Things are slightly different on Windows, where the driver manager will also search for driver information in the registry just as would happen for ODBC drivers. The search for a manifest on Windows would be the following: -#. If the ``LOAD_FLAG_SEARCH_ENV`` load option is set, then the environment variable ``ADBC_CONFIG_PATH`` will be searched +#. If the ``LOAD_FLAG_SEARCH_ENV`` load option is set, then the environment variables will be searched in this order * ``ADBC_CONFIG_PATH`` is a semicolon-separated list of directories to search for ``${name}.toml`` + * ``VIRTUAL_ENV`` is used by `venv <https://docs.python.org/3/library/venv.html>`__ and if set + ``$VIRTUAL_ENV/etc/adbc`` will be searched for ``${name}.toml`` + * ``CONDA_PREFIX`` is used by `conda <https://anaconda.org/anaconda/conda>`__ when using a ``conda`` + environment (by using ``conda activate env-name``), and if set then ``$CONDA_PREFIX/etc/adbc`` + will be searched for ``${name}.toml`` Review Comment: Same here ```suggestion * ``CONDA_PREFIX`` is used by `conda <https://anaconda.org/anaconda/conda>`__ and if set ``$CONDA_PREFIX/etc/adbc`` will be searched for ``${name}.toml`` ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org