ianmcook commented on code in PR #3320:
URL: https://github.com/apache/arrow-adbc/pull/3320#discussion_r2289335204


##########
docs/source/format/driver_manifests.rst:
##########
@@ -431,9 +431,14 @@ Unix-like Platforms
 For Unix-like platforms, (e.g. Linux, macOS), the driver manager will search 
the following directories based on the options provided, in
 the given order:
 
-#. If the ``LOAD_FLAG_SEARCH_ENV`` load option is set, then the environment 
variable ``ADBC_CONFIG_PATH`` will be searched
+#. If the ``LOAD_FLAG_SEARCH_ENV`` load option is set, then environment 
variables will be searched in this order
 
    * ``ADBC_CONFIG_PATH`` is a colon-separated list of directories to search 
for ``${name}.toml``
+   * ``VIRTUAL_ENV`` is used by `venv 
<https://docs.python.org/3/library/venv.html>`__ and if set
+     ``$VIRTUAL_ENV/etc/adbc`` will be searched for ``${name}.toml``
+   * ``CONDA_PREFIX`` is used by `conda 
<https://anaconda.org/anaconda/conda>`__ when using a ``conda``
+     environment (by using ``conda activate env-name``), and if set then 
``$CONDA_PREFIX/etc/adbc``
+     will be searched for ``${name}.toml``

Review Comment:
   I think it'd be OK to omit the details to make this shorter:
   ```suggestion
      * ``CONDA_PREFIX`` is used by `conda 
<https://anaconda.org/anaconda/conda>`__ and if set
        ``$CONDA_PREFIX/etc/adbc`` will be searched for ``${name}.toml``
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to