scovich commented on code in PR #8105:
URL: https://github.com/apache/arrow-rs/pull/8105#discussion_r2291313444
##########
parquet-variant-compute/src/type_conversion.rs:
##########
@@ -54,7 +55,7 @@ macro_rules! non_generic_conversion_single_value {
#[macro_export]
Review Comment:
nit: There's no point (publicly) exporting a macro that references `$crate`
-- compilation will fail for any use sites outside this crate. Can do
`pub(crate) use generic_conversion_array` to make it visible everywhere inside
the crate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
