scovich commented on PR #8105: URL: https://github.com/apache/arrow-rs/pull/8105#issuecomment-3210969318
> The last commit added `#[allow(unused_imports)]` before the `use half::f16;`, because if we don't add this, CI will complain that `unused import: `half::f16`, but if we remove this import, then the ci complains as [this](https://github.com/apache/arrow-rs/actions/runs/17128573144/job/48586341745?pr=8105) (sample as below) > > And also not sure why the CI didn't fail before, the `import half::f16` has been added some time ago in #8073. > > ``` > ... > error[E0658]: the type `f16` is unstable > --> parquet-variant-compute/src/cast_to_variant.rs:827:22 > | > 827 | Some(f16::MIN), > | ^^^ > ... > ``` Ah! The latter is in the `#[cfg(test)] mod test` which has a `use super::*`. If you just move the `use half::f16` to `mod test` the problem should go away. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
