zeroshade commented on PR #3320: URL: https://github.com/apache/arrow-adbc/pull/3320#issuecomment-3211614395
@amoeba correct, that's the current logic. Installing the PyPI adbc_driver_manager package would not perform automatic checking of your conda env, (but it would recognize a venv), and installing it from conda would then recognize the conda_prefix env var and check for it. I was following @paleolimbot's suggestion of only checking `CONDA_PREFIX` if built for conda. I'm on the fence personally as to which makes more sense.... I'll leave that to you guys to duke out and I'll just implement whatever is decided. @ianmcook you're right, I didn't update the docs to fit the new behavior yet. Thanks for taking on the updates there. you should be able to just push to this PR any doc updates you make. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
