hiroyuki-sato opened a new pull request, #47403:
URL: https://github.com/apache/arrow/pull/47403
### Rationale for this change
This is the sub issue #44748.
* SC2086: Double quote to prevent globbing and word splitting
* SC2012: Use find instead of ls to better handle non-alphanumeric filenames
```
shellcheck ci/scripts/python_test_emscripten.sh
In ci/scripts/python_test_emscripten.sh line 28:
cd ${build_dir}
^----------^ SC2086 (info): Double quote to prevent globbing and word
splitting.
Did you mean:
cd "${build_dir}"
In ci/scripts/python_test_emscripten.sh line 31:
pyodide_wheel=$(ls -t dist/pyarrow*.whl | head -1)
^---------------------^ SC2012 (info): Use find instead of
ls to better handle non-alphanumeric filenames.
In ci/scripts/python_test_emscripten.sh line 34:
python scripts/run_emscripten_tests.py ${pyodide_wheel}
--dist-dir=${pyodide_dist_dir} --runtime=node
^--------------^ SC2086 (info):
Double quote to prevent globbing and word splitting.
^-----------------^ SC2086 (info): Double quote to prevent globbing and word
splitting.
Did you mean:
python scripts/run_emscripten_tests.py "${pyodide_wheel}"
--dist-dir="${pyodide_dist_dir}" --runtime=node
In ci/scripts/python_test_emscripten.sh line 37:
python scripts/run_emscripten_tests.py ${pyodide_wheel}
--dist-dir=${pyodide_dist_dir} --runtime=chrome
^--------------^ SC2086 (info):
Double quote to prevent globbing and word splitting.
^-----------------^ SC2086 (info): Double quote to prevent globbing and word
splitting.
Did you mean:
python scripts/run_emscripten_tests.py "${pyodide_wheel}"
--dist-dir="${pyodide_dist_dir}" --runtime=chrome
For more information:
https://www.shellcheck.net/wiki/SC2012 -- Use find instead of ls to better
...
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing
...
```
### What changes are included in this PR?
* SC2086: Quote variables.
* SC2012: skip shellcheck.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
