hiroyuki-sato commented on code in PR #47403:
URL: https://github.com/apache/arrow/pull/47403#discussion_r2292469016


##########
ci/scripts/python_test_emscripten.sh:
##########
@@ -25,14 +25,15 @@ set -ex
 build_dir=${1}/python
 pyodide_dist_dir=${2}
 
-cd ${build_dir}
+cd "${build_dir}"
 
 # note: this uses the newest wheel in dist
+# shellcheck disable=SC2012

Review Comment:
   This part use `ls` with `-t`  option, so we can't use `echo`.
   I don't know alternate command which is usable on macOS / Linux.
   (As far as I know, `find` and `stat` can't use the same option on macOS / 
Linux)
   
   ```python
   latest=$(python3 -c '
   import glob, os
   files = glob.glob("dist/pyarrow*.whl")
   if files:
       print(max(files, key=os.path.getmtime))
   ')
   echo "$latest"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to