mbrobbel commented on PR #3245: URL: https://github.com/apache/arrow-adbc/pull/3245#issuecomment-3215253157
> I was hoping Matthijs could take another look but we can always do breaking changes if we change our mind so go for it I was mostly offline for a few weeks (🏕️) - I think there is added value in keeping `non_exhaustive` for the enums where we expect we'll be adding variants, because it helps downstream users to easily update this crate without having to explicitly handle variant additions that are tied to an updated adbc version (so non-breaking for the crate version) that they don't want to directly provide support for i.e. their crate update is not blocked on having to support the added variants because they don't support that adbc version. It's a bit unclear to me if this is something that would ever happen, so I'm fine with just keeping things as they are with this PR merged and we'll learn as we move things forward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
