pitrou commented on code in PR #46992:
URL: https://github.com/apache/arrow/pull/46992#discussion_r2297996497
##########
cpp/src/parquet/printer.cc:
##########
@@ -342,6 +350,22 @@ void ParquetFilePrinter::JSONPrint(std::ostream& stream,
std::list<int> selected
<< R"("Min": ")"
<< FormatStatValue(descr->physical_type(), min,
descr->logical_type())
<< "\"";
+ if (stats->is_max_value_exact().has_value()) {
+ stream << ", "
+ << R"("IsMaxValueExact": ")"
+ << (stats->is_max_value_exact().value() ? "True" : "False")
<< "\"";
+ } else {
+ stream << ", "
+ << R"("IsMaxValueExact": "unknown")";
Review Comment:
I was going to suggest that we should be using the JSON literals `true`,
`false` and `null` rather than strings, but I see that we're already using
strings instead of actual JSON bools (which is stupid but hey).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
