pitrou commented on code in PR #46992:
URL: https://github.com/apache/arrow/pull/46992#discussion_r2298019469
##########
cpp/src/parquet/statistics.h:
##########
@@ -215,12 +220,15 @@ class PARQUET_EXPORT Statistics {
/// \param[in] has_min_max whether the min/max statistics are set
/// \param[in] has_null_count whether the null_count statistics are set
/// \param[in] has_distinct_count whether the distinct_count statistics are
set
+ /// \param[in] is_min_value_exact whether the min value is exact
+ /// \param[in] is_max_value_exact whether the max value is exact
/// \param[in] pool a memory pool to use for any memory allocations, optional
static std::shared_ptr<Statistics> Make(
const ColumnDescriptor* descr, const std::string& encoded_min,
const std::string& encoded_max, int64_t num_values, int64_t null_count,
int64_t distinct_count, bool has_min_max, bool has_null_count,
- bool has_distinct_count,
+ bool has_distinct_count, std::optional<bool> is_min_value_exact,
+ std::optional<bool> is_max_value_exact,
Review Comment:
I don't know. @wgtmac What do you think?
We might even want to design the new API more radically, e.g.:
```c++
static std::shared_ptr<Statistics> Make(
const ColumnDescriptor* descr,
int64_t num_values,
const std::optional<std::string_view>& encoded_min,
const std::optional<std::string_view>& encoded_max,
std::optional<int64_t> null_count,
std::optional<int64_t> distinct_count,
::arrow::MemoryPool* pool = ::arrow::default_memory_pool());
```
but that also means more call sites must be adapted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
