BlakeOrth commented on code in PR #8222:
URL: https://github.com/apache/arrow-rs/pull/8222#discussion_r2301636483
##########
arrow-schema/src/extension/canonical/geometry.rs:
##########
@@ -0,0 +1,136 @@
+use crate::extension::ExtensionType;
+use crate::ArrowError;
+
+/// Geospatial features in the WKB format with linear/planar edges
interpolation
+#[derive(Debug, Default, Clone, PartialEq, Eq, Hash)]
+pub struct Geometry {
+ crs: Option<String>,
Review Comment:
Interesting, so if I understand correctly this implies that it's always
possible to convert Parquet geospatial types into valid GeoArrow (CRS is always
known, either explicit or the spec defined default), but not all GeoArrow may
be safely serialized as Parquet (an unset CRS is ambiguous).
If the above is true, it seems like this may be a trade off between ensuring
correctness and broader ecosystem compatibility when serializing to parquet.
This is one of those scenarios where there's probably not a "right" answer. I
would personally err on the side of ensuring correctness, and error when the
input Arrow data cannot be safely serialized to parquet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
