paleolimbot commented on code in PR #8222:
URL: https://github.com/apache/arrow-rs/pull/8222#discussion_r2301708973


##########
arrow-schema/src/extension/canonical/geometry.rs:
##########
@@ -0,0 +1,136 @@
+use crate::extension::ExtensionType;
+use crate::ArrowError;
+
+/// Geospatial features in the WKB format with linear/planar edges 
interpolation
+#[derive(Debug, Default, Clone, PartialEq, Eq, Hash)]
+pub struct Geometry {
+    crs: Option<String>,

Review Comment:
   Yes, an "unset" GeoArrow CRS should probably error on conversion to a 
Parquet type. I don't feel too strongly about this...Arrow C++ doesn't error 
here at the moment because it was pragmatic at the time (it allowed a suite of 
tests to pass without a JSON parser, which at the time required adding a C++ 
dependency that I wasn't sure would work).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to