lidavidm commented on PR #3362: URL: https://github.com/apache/arrow-adbc/pull/3362#issuecomment-3232208232
The Python side is not fully wired up yet but I would appreciate opinions on using an option to tell drivers to bind parameters by name and not position. @zeroshade @amoeba @WillAyd @paleolimbot My reasoning: - I'm not sure we can auto-detect what the user intends. At least for SQLite, we can detect whether parameter names are in play and then check if the schema matches? But this is more complicated (especially if the order doesn't match) and fragile. So I think explicitly opting in to this behavior is best. - We could flag this in the schema metadata, which is attractive as it's stateless. But also it can silently be ignored if the driver doesn't support the option and requires fiddling with the schema (and potentially copying it depending on your Arrow implementation). So an explicit option is better. The tests in this PR aren't complete yet on the Python side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
