jorisvandenbossche commented on a change in pull request #9996:
URL: https://github.com/apache/arrow/pull/9996#discussion_r613995674
##########
File path: python/pyarrow/tests/test_fs.py
##########
@@ -1052,6 +1052,45 @@ def test_s3_options(monkeypatch):
)
[email protected]
+def test_s3_proxy_options(monkeypatch):
+ from pyarrow.fs import S3FileSystem
+
+ # Avoid wait for unavailable metadata server in ARN role example below
+ monkeypatch.setenv("AWS_EC2_METADATA_DISABLED", "true")
+
+ # Check dict case for 'proxy_options'
+ fs = S3FileSystem(proxy_options={'scheme': 'http', 'host': 'localhost',
+ 'port': 8999})
+ assert isinstance(fs, S3FileSystem)
+ assert pickle.loads(pickle.dumps(fs)) == fs
Review comment:
Could you also add a check that two filesystems with different (or one
with no) proxy options don't evaluate as equal?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
