pitrou commented on a change in pull request #9996:
URL: https://github.com/apache/arrow/pull/9996#discussion_r614091530
##########
File path: python/pyarrow/tests/test_fs.py
##########
@@ -1052,6 +1052,50 @@ def test_s3_options(monkeypatch):
)
[email protected]
+def test_s3_proxy_options(monkeypatch):
+ from pyarrow.fs import S3FileSystem
+
+ # Avoid wait for unavailable metadata server in ARN role example below
+ monkeypatch.setenv("AWS_EC2_METADATA_DISABLED", "true")
Review comment:
Doesn't seem useful? There's no ARN role example below :-)
##########
File path: python/pyarrow/tests/test_fs.py
##########
@@ -1052,6 +1052,50 @@ def test_s3_options(monkeypatch):
)
[email protected]
+def test_s3_proxy_options(monkeypatch):
+ from pyarrow.fs import S3FileSystem
+
+ # Avoid wait for unavailable metadata server in ARN role example below
+ monkeypatch.setenv("AWS_EC2_METADATA_DISABLED", "true")
+
+ # Check dict case for 'proxy_options'
+ fs1 = S3FileSystem(proxy_options={'scheme': 'http', 'host': 'localhost',
+ 'port': 8999})
+ assert isinstance(fs1, S3FileSystem)
+ assert pickle.loads(pickle.dumps(fs1)) == fs1
+
+ # Check str case for 'proxy_options'
+ fs2 = S3FileSystem(proxy_options='http://localhost:9000')
+ assert isinstance(fs2, S3FileSystem)
+ assert pickle.loads(pickle.dumps(fs2)) == fs2
+
Review comment:
Can you check inequality between two different set of proxy options?
Can you also check equality of equivalent proxy options create from a dict
or a URI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
