nathaniel-d-ef commented on code in PR #8242:
URL: https://github.com/apache/arrow-rs/pull/8242#discussion_r2310259517
##########
arrow-avro/benches/decoder.rs:
##########
@@ -369,42 +405,55 @@ const MIX_SCHEMA: &str =
r#"{"type":"record","name":"MixRec","fields":[{"name":"
const NEST_SCHEMA: &str =
r#"{"type":"record","name":"NestRec","fields":[{"name":"sub","type":{"type":"record","name":"Sub","fields":[{"name":"x","type":"int"},{"name":"y","type":"string"}]}}]}"#;
macro_rules! dataset {
- ($name:ident, $schema_json:expr, $gen_fn:ident) => {
+ (@impl $name:ident, $schema_json:expr, $gen_fn:ident, $prefix_size:expr,
$fingerprint_expr:expr) => {
static $name: Lazy<Vec<Vec<u8>>> = Lazy::new(|| {
let schema =
ApacheSchema::parse_str($schema_json).expect("invalid schema
for generator");
Review Comment:
Fair, I went back and forth on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
