nathaniel-d-ef commented on code in PR #8242:
URL: https://github.com/apache/arrow-rs/pull/8242#discussion_r2311447710
##########
arrow-avro/src/reader/mod.rs:
##########
@@ -773,6 +810,19 @@ mod test {
.expect("decoder")
}
+ fn make_id_prefix(id: u32) -> Vec<u8> {
+ let mut out = Vec::with_capacity(1 + 4);
Review Comment:
The Confluent spec outlines a 4 byte id plus the magic byte, so it should be
sufficient. I went ahead and removed the hardcoded values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
