behrisch commented on code in PR #47114: URL: https://github.com/apache/arrow/pull/47114#discussion_r2312367919
########## cpp/src/parquet/column_reader.cc: ########## @@ -57,6 +57,11 @@ #include "parquet/thrift_internal.h" // IWYU pragma: keep #include "parquet/windows_fixup.h" // for OPTIONAL +#ifdef _MSC_VER Review Comment: I am not sure whether this is a good idea. `parquet/windows_fixup.h` is again part of the public facing API (via parquet/schema.h) so we would need to do push / pop again to avoid disabling the warning for everyone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
