wgtmac commented on code in PR #47114: URL: https://github.com/apache/arrow/pull/47114#discussion_r2312774872
########## cpp/src/parquet/column_reader.cc: ########## @@ -57,6 +57,11 @@ #include "parquet/thrift_internal.h" // IWYU pragma: keep #include "parquet/windows_fixup.h" // for OPTIONAL +#ifdef _MSC_VER Review Comment: I was thinking of defining some common macros for these but it seems that these patterns have already been scattered around. WDYT? @kou -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
