mbrobbel commented on code in PR #3381:
URL: https://github.com/apache/arrow-adbc/pull/3381#discussion_r2312657416
##########
rust/core/src/options.rs:
##########
@@ -37,7 +37,7 @@ pub enum OptionValue {
impl OptionValue {
/// Gets the data type of the option's value.
- pub(crate) fn get_type(&self) -> &str {
+ pub fn get_type(&self) -> &str {
Review Comment:
`type_name` is better - but looking at this again I would actually suggest
to move this methods to the crate where it is used and not add a `pub` method
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
