mbrobbel commented on code in PR #3381:
URL: https://github.com/apache/arrow-adbc/pull/3381#discussion_r2315141584
##########
rust/core/src/options.rs:
##########
@@ -37,7 +37,7 @@ pub enum OptionValue {
impl OptionValue {
/// Gets the data type of the option's value.
- pub(crate) fn get_type(&self) -> &str {
+ pub fn get_type(&self) -> &str {
Review Comment:
I was a bit confused about the comment, function name and signature, and I
assumed this wouldn't be used by others (outside of the use here to build an
error message). If we `pub` it we should maybe update the docs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
