zanmato1984 commented on code in PR #43698: URL: https://github.com/apache/arrow/pull/43698#discussion_r2313160280
########## cpp/src/arrow/util/thread_pool.h: ########## @@ -593,6 +594,7 @@ typename Fut::SyncType RunSynchronously(FnOnce<Fut(Executor*)> get_future, } /// \brief Potentially iterate an async generator serially (if use_threads is false) +/// using a potentially custom Executor /// \see IterateGenerator /// /// If `use_threads` is true, the global CPU executor will be used. Each call to Review Comment: ```suggestion /// If `use_threads` is true, the custom executor or, if null, the global CPU executor will be used. Each call to ``` ########## cpp/src/arrow/util/thread_pool.h: ########## @@ -603,11 +605,16 @@ typename Fut::SyncType RunSynchronously(FnOnce<Fut(Executor*)> get_future, /// the iterator will use the calling thread to do enough work to generate one item. /// Tasks will be left in a queue until the next call and no work will be done between /// calls. +/// +/// If `executor` is null, then the default CPU thread pool will be used. Review Comment: Other than adding this, we should probably update line 600. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
