kou commented on code in PR #47476:
URL: https://github.com/apache/arrow/pull/47476#discussion_r2320252683
##########
cpp/CMakeLists.txt:
##########
@@ -351,6 +351,12 @@ endif()
include(SetupCxxFlags)
+if(${CMAKE_CXX_FLAGS_DEBUG} MATCHES "-Og")
Review Comment:
No.
In general, we should not use `add_definitions()` because its scope is
global. We should create a target and use it instead:
```cmake
add_library(arrow::xxhash INTERFACE IMPORTED)
target_compile_definitions(arrow::xxhash INTERFACE
"$<$<CONFIG:Debug>:XXH_NO_INLINE_HINTS>")
```
(I think that we don't need `-Og` check. We can always disable inline hints
in debug build.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
