kou commented on code in PR #47476:
URL: https://github.com/apache/arrow/pull/47476#discussion_r2321031269
##########
cpp/CMakeLists.txt:
##########
@@ -351,6 +351,12 @@ endif()
include(SetupCxxFlags)
+if(${CMAKE_CXX_FLAGS_DEBUG} MATCHES "-Og")
Review Comment:
Yes when they need additional build flags. If they don't need additional
build flags, we don't need to create targets for them. Because we have `src/`
in include paths:
https://github.com/apache/arrow/blob/743d0afd05573f0160ab9e15d09bd79a5387d1a4/cpp/CMakeLists.txt#L559-L560
BTW, we should not use `include_directories()` because its scope is global
(directory) too...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
