alamb commented on code in PR #8227:
URL: https://github.com/apache/arrow-rs/pull/8227#discussion_r2323000661
##########
arrow-cast/src/pretty.rs:
##########
@@ -60,7 +60,7 @@ use crate::display::{ArrayFormatter, FormatOptions};
/// | 5 | e |
/// +---+---+"#);
/// ```
-pub fn pretty_format_batches(results: &[RecordBatch]) -> Result<impl Display,
ArrowError> {
+pub fn pretty_format_batches(results: &[RecordBatch]) -> Result<impl Display +
use<>, ArrowError> {
Review Comment:
What is the implication of this change for users of this crate? I assume it
is a no-op but I am not familiar with the `use` syntax
##########
arrow-ipc/src/gen/Schema.rs:
##########
@@ -97,16 +97,20 @@ impl<'a> flatbuffers::Follow<'a> for MetadataVersion {
type Inner = Self;
#[inline]
unsafe fn follow(buf: &'a [u8], loc: usize) -> Self::Inner {
- let b = flatbuffers::read_scalar_at::<i16>(buf, loc);
- Self(b)
+ unsafe {
Review Comment:
since this file is automatically generated by flatbuffers compiler, can we
avoid these changes (maybe by suppressing whatever compiler lint / or hard
coding this file to use the old edition?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
