jorisvandenbossche commented on a change in pull request #10054:
URL: https://github.com/apache/arrow/pull/10054#discussion_r614293940



##########
File path: python/pyarrow/io.pxi
##########
@@ -1449,6 +1449,10 @@ cdef shared_ptr[CBuffer] as_c_buffer(object o) except *:
 
 
 cdef NativeFile get_native_file(object source, c_bool use_memory_map):
+    if source is None:

Review comment:
       I suggested to add `object source not None` in the signature (that would 
automatically give a better error message), but so apparently that only works 
for `def` functions and not for `cdef` functions.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to