pitrou commented on a change in pull request #10054:
URL: https://github.com/apache/arrow/pull/10054#discussion_r615867888



##########
File path: python/pyarrow/io.pxi
##########
@@ -1449,6 +1449,10 @@ cdef shared_ptr[CBuffer] as_c_buffer(object o) except *:
 
 
 cdef NativeFile get_native_file(object source, c_bool use_memory_map):
+    if source is None:

Review comment:
       Again, I'm not sure what the concern is. Is it common to pass `None` 
instead of a file object? It's not an optional parameter, so I don't know where 
the `None` could come from.
   
   (also, getting this kind of `AttributeError` when passing the wrong type is 
quite common in Python)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to