scovich commented on PR #8324: URL: https://github.com/apache/arrow-rs/pull/8324#issuecomment-3285463911
> after your updates to have everything use the same indirection mechanism, it seems that many benchmarks got slower -- I think we should revert to having the specific enums. I am sorry for any confusion / rework I have caused. Honestly, that tells me we just don't have benchmarks to measure the impact of the original change, and that we either need to go generic or accept the architectural violation of having enum variants for array builders (but the latter would be difficult to pull off, given that `NullBuffer` is part of the builder specific state, and arrow-array is not available in parquet-variant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
