scovich commented on PR #8324: URL: https://github.com/apache/arrow-rs/pull/8324#issuecomment-3285709479
@alamb -- I changed to generic `ParentState<S: BuilderSpecificState>`, could you take it for a benchmarking spin so we know what impact it has? Meanwhile: * `VariantBuilderExt` did _not_ become generic -- it can capture the genericity with an associated type instead. * Changing to generic only seems to have affected code implementing builders and parent state; I didn't have to change any use sites. * The PR is still a net win in LoC, in spite of that churn. Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
