nathaniel-d-ef commented on code in PR #8298:
URL: https://github.com/apache/arrow-rs/pull/8298#discussion_r2344484538
##########
arrow-avro/src/writer/encoder.rs:
##########
@@ -112,6 +222,64 @@ impl<'a> FieldEncoder<'a> {
nullability: Option<Nullability>,
) -> Result<Self, ArrowError> {
let encoder = match plan {
+ FieldPlan::Scalar => match array.data_type() {
+ DataType::Boolean =>
Encoder::Boolean(BooleanEncoder(array.as_boolean())),
+ DataType::Utf8 => {
+
Encoder::Utf8(Utf8GenericEncoder::<i32>(array.as_string::<i32>()))
+ }
+ DataType::LargeUtf8 => {
+
Encoder::Utf8Large(Utf8GenericEncoder::<i64>(array.as_string::<i64>()))
+ }
+ DataType::Int32 =>
Encoder::Int(IntEncoder(array.as_primitive::<Int32Type>())),
+ DataType::Int64 =>
Encoder::Long(LongEncoder(array.as_primitive::<Int64Type>())),
+ DataType::Float32 => {
+
Encoder::Float32(F32Encoder(array.as_primitive::<Float32Type>()))
+ }
+ DataType::Float64 => {
+
Encoder::Float64(F64Encoder(array.as_primitive::<Float64Type>()))
+ }
+ DataType::Binary =>
Encoder::Binary(BinaryEncoder(array.as_binary::<i32>())),
+ DataType::LargeBinary => {
+
Encoder::LargeBinary(BinaryEncoder(array.as_binary::<i64>()))
+ }
+ DataType::FixedSizeBinary(len) => {
+ let arr = array
+ .as_any()
+ .downcast_ref::<FixedSizeBinaryArray>()
+ .ok_or_else(|| {
+ ArrowError::SchemaError("Expected
FixedSizeBinaryArray".into())
+ })?;
+ Encoder::Fixed(FixedEncoder(arr))
+ }
+ DataType::Timestamp(TimeUnit::Microsecond, _) =>
Encoder::Timestamp(LongEncoder(
+ array.as_primitive::<TimestampMicrosecondType>(),
+ )),
+ DataType::Interval(unit) => match unit {
+ IntervalUnit::MonthDayNano => {
+ Encoder::IntervalMonthDayNano(DurationEncoder(
+ array.as_primitive::<IntervalMonthDayNanoType>(),
+ ))
+ }
+ IntervalUnit::YearMonth => {
+ Encoder::IntervalYearMonth(DurationEncoder(
+ array.as_primitive::<IntervalYearMonthType>(),
+ ))
+ }
+ IntervalUnit::DayTime =>
Encoder::IntervalDayTime(DurationEncoder(
+ array.as_primitive::<IntervalDayTimeType>(),
+ )),
+ }
+ DataType::Duration(_) => {
+ return Err(ArrowError::NotYetImplemented(
+ "Avro writer: Arrow Duration(TimeUnit) has no standard
Avro mapping; cast to Interval(MonthDayNano) to use Avro 'duration'".into(),
Review Comment:
This will be completed in a follow up PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
