nathaniel-d-ef commented on PR #8298: URL: https://github.com/apache/arrow-rs/pull/8298#issuecomment-3285735761
> > @alamb Yes, good callout. I have additional round trip tests a fast-follow up [draft PR](https://github.com/apache/arrow-rs/pull/8308), but I'll apply @jecsand838 's recommendation here too for decimals. I also plan to do a wrap-up PR to cover any gaps in the tests, docs, etc. > > Round trip tests in a follow on PR sounds good to me -- thank you > > Note I still think there is value is direct round trip tests where the source data was created directly in memory as Arrow rather than being read from an existing file. This would ensure there is a pattern to cover all potential data types and would be easy to add additional cases to (without having to create / check in a avro file from some other systems) > > However, the round trip tests in #8308 look reasonable > > Thanks for pushing this along. Please just give me a ping when it is ready for another look @alamb That's a good point that I hadn't considered. I'll work on that pattern for the coming PRs. Thanks again for digging in here; it's good for another review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
