mbrobbel commented on code in PR #8290:
URL: https://github.com/apache/arrow-rs/pull/8290#discussion_r2348372913
##########
arrow-array/src/builder/mod.rs:
##########
@@ -604,7 +604,7 @@ pub fn make_builder(datatype: &DataType, capacity: usize)
-> Box<dyn ArrayBuilde
DataType::Int32 => dict_builder!(Int32Type),
DataType::Int64 => dict_builder!(Int64Type),
_ => {
- panic!("Data type {t:?} with key type {key_type:?} is not
currently supported")
+ panic!("Data type {t:?} with key type {key_type} is not
currently supported")
Review Comment:
```suggestion
panic!("Data type {t} with key type {key_type} is not
currently supported")
```
##########
arrow-array/src/builder/struct_builder.rs:
##########
@@ -267,7 +267,7 @@ impl StructBuilder {
let schema = builder.finish();
panic!("{}", format!(
- "StructBuilder ({:?}) and field_builder with index {}
({:?}) are of unequal lengths: ({} != {}).",
+ "StructBuilder ({}) and field_builder with index {} ({})
are of unequal lengths: ({} != {}).",
schema,
idx,
Review Comment:
```suggestion
panic!("{}", format!(
"StructBuilder ({schema}) and field_builder with index
{idx} ({}) are of unequal lengths: ({} != {}).",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
