emilk commented on code in PR #8290: URL: https://github.com/apache/arrow-rs/pull/8290#discussion_r2339317466
########## arrow-schema/src/datatype_format.rs: ########## @@ -0,0 +1,263 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use std::{collections::HashMap, fmt}; + +use crate::DataType; + +impl fmt::Display for DataType { + fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { + // NOTE: `Display` and `Debug` formatting are ALWAYS the same, Review Comment: I know this is uncommon, but unfortunately so many error messages in datafusion and arrow use the `Debug` formatting of `DataType` instead of `Display`, which means we end up with huge diffult-to-read error messages. There are three solutions to this, afaict: A) Use `Display` for `Debug`, like this PR. It's still programmer-facing, because it contains ALL the info (metadata etc) B) Replace all uses of `{:?}` with `{}` when printing datatypes in datafusion, arrow, and other third party crates. This is VERY hard to do, as I know of no automated tool to find all these places. C) Improve `Debug` formatting by omitting empty/default fields. This will _help_, but the Debug format for `DataType::List` will still be very ugly, since it wraps a `Field`. ########## arrow-schema/src/datatype_format.rs: ########## @@ -0,0 +1,263 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use std::{collections::HashMap, fmt}; + +use crate::DataType; + +impl fmt::Display for DataType { + fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { + // NOTE: `Display` and `Debug` formatting are ALWAYS the same, Review Comment: I know this is uncommon, but unfortunately so many error messages in datafusion and arrow use the `Debug` formatting of `DataType` instead of `Display`, which means we end up with huge difficult-to-read error messages. There are three solutions to this, afaict: A) Use `Display` for `Debug`, like this PR. It's still programmer-facing, because it contains ALL the info (metadata etc) B) Replace all uses of `{:?}` with `{}` when printing datatypes in datafusion, arrow, and other third party crates. This is VERY hard to do, as I know of no automated tool to find all these places. C) Improve `Debug` formatting by omitting empty/default fields. This will _help_, but the Debug format for `DataType::List` will still be very ugly, since it wraps a `Field`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
