mathyingzhou commented on a change in pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#discussion_r614575581
##########
File path: cpp/src/arrow/adapters/orc/adapter_util.cc
##########
@@ -15,38 +15,46 @@
// specific language governing permissions and limitations
// under the License.
+#include "arrow/adapters/orc/adapter_util.h"
+
+#include <cmath>
#include <string>
#include <vector>
-#include "arrow/adapters/orc/adapter_util.h"
#include "arrow/array/builder_base.h"
#include "arrow/builder.h"
+#include "arrow/chunked_array.h"
+#include "arrow/scalar.h"
#include "arrow/status.h"
+#include "arrow/util/bitmap_ops.h"
#include "arrow/util/checked_cast.h"
#include "arrow/util/decimal.h"
#include "arrow/util/range.h"
-
+#include "arrow/util/string_view.h"
+#include "arrow/visitor_inline.h"
#include "orc/Exceptions.hh"
+#include "orc/MemoryPool.hh"
#include "orc/OrcFile.hh"
+// The number of milliseconds, microseconds and nanoseconds in a second
+constexpr int64_t kOneSecondMillis = 1000LL;
+constexpr int64_t kOneMicroNanos = 1000LL;
+constexpr int64_t kOneSecondMicros = 1000000LL;
+constexpr int64_t kOneMilliNanos = 1000000LL;
+constexpr int64_t kOneSecondNanos = 1000000000LL;
// alias to not interfere with nested orc namespace
namespace liborc = orc;
-namespace arrow {
-
-namespace adapters {
-
-namespace orc {
Review comment:
On `WriteBatch`: Doc added and parameters rotated so that they make more
sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
