mathyingzhou commented on a change in pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#discussion_r614743037



##########
File path: python/pyarrow/tests/test_orc.py
##########
@@ -26,140 +24,13 @@
 pytestmark = pytest.mark.orc
 
 
-try:

Review comment:
       @pitrou Fair enough. Well, back then in Dec and Jan I did manual tests 
using the ORC adapter to write ORC files and then loaded them using pyorc and 
compared the results. So we should be good.
   
   Of course in the future I can add some more tests (read using Arrow, write 
without Arrow and vice versa). Can we get this PR out there though? The 
functionality has been very stable since early Jan and the amount of bugs 
affecting the actual ORC files we have caught during the past 3 months is 2-4.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to