rok commented on code in PR #8162:
URL: https://github.com/apache/arrow-rs/pull/8162#discussion_r2359994359
##########
parquet/src/arrow/arrow_writer/mod.rs:
##########
@@ -426,6 +428,15 @@ impl<W: Write + Send> ArrowWriter<W> {
row_group_writer.close()?;
Ok(())
}
+
+ /// Converts this writer into a lower-level [`SerializedFileWriter`] and
[`ArrowRowGroupWriterFactory`].
Review Comment:
Agreed it's odd. Motivation was to introduce as few new `pub`s as possible.
Would be very curious about alternative API shapes.
##########
parquet/src/arrow/async_writer/mod.rs:
##########
@@ -288,34 +288,17 @@ impl<W: AsyncFileWriter> AsyncArrowWriter<W> {
Ok(())
}
-
- /// Create a new row group writer and return its column writers.
- pub async fn get_column_writers(&mut self) ->
Result<Vec<ArrowColumnWriter>> {
Review Comment:
It is very fresh indeed. I hope we're not spoiling some plan here. We did
find the `ArrowRowGroupWriterFactory` route better so I think it should be ok.
##########
parquet/src/arrow/async_writer/mod.rs:
##########
@@ -349,51 +332,6 @@ mod tests {
assert_eq!(to_write, read);
}
- #[tokio::test]
Review Comment:
Agreed.
##########
parquet/src/arrow/arrow_writer/mod.rs:
##########
@@ -426,6 +428,15 @@ impl<W: Write + Send> ArrowWriter<W> {
row_group_writer.close()?;
Ok(())
}
+
+ /// Converts this writer into a lower-level [`SerializedFileWriter`] and
[`ArrowRowGroupWriterFactory`].
+ /// This can be useful to provide more control over how files are written.
+ pub fn into_serialized_writer(
Review Comment:
Agreed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
