adamreeve commented on PR #8162: URL: https://github.com/apache/arrow-rs/pull/8162#issuecomment-3310232231
> I am sorry I haven't found time to study this PR in detail. @adamreeve it sounds like you have some good ideas and have devoted time here. What would you recommend? I've read through the latest comments and it sounds like you have a good understanding of the motivation for this change now, thanks for taking a close look Andrew. I agree it would be good to consolidate on using `ArrowRowGroupWriterFactory` for concurrent writing and update the examples. And also agree that creating an `ArrowWriter` just to convert it straight away to an `ArrowRowGroupWriterFactory` is a bit awkward. It does conveniently also create a `SerializedFileWriter` using the Arrow schema, but that's not too complicated to do explicitly, and the existing concurrent writing example already does this. If you'd rather not have the new `into_serialized_writer` method and require creating the `ArrowRowGroupWriterFactory` directly, maybe we should take some more time to implement your suggested approach and wait for the next release. But I think `into_serialized_writer` is convenient and unlikely to cause much extra maintenance burden. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
