adamreeve commented on code in PR #8445:
URL: https://github.com/apache/arrow-rs/pull/8445#discussion_r2380418073
##########
parquet/tests/encryption/encryption_async.rs:
##########
@@ -818,8 +818,10 @@ async fn test_multi_threaded_encrypted_writing() {
let metadata = serialized_file_writer.close().unwrap();
// Close the file writer which writes the footer
- assert_eq!(metadata.num_rows, 50);
- assert_eq!(metadata.schema, metadata.schema);
+ assert_eq!(metadata.file_metadata().num_rows(), 50);
+ // TODO(ets): what was this meant to test? The read and written schemas
differ because an
+ // archaic form for a list was used in the source file.
+ // assert_eq!(metadata.schema, metadata.schema);
Review Comment:
I guess this was supposed to verify that after we write the encrypted file
the schema matches the original input, as your comment suggests. But it's
clearly not doing that!
I don't think this is necessary, the schemas shouldn't need to match
exactly, and `verify_encryption_test_data` already tests all the columns
expected are there and will verify the arrow types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
